Fix logger name in HalFormsAdaptingResponseBodyAdvice
#2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.logging.slf4j.LoggersNamedForEnclosingClass?organizationId=U3ByaW5n Co-authored-by: Moderne <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
reviewed
May 16, 2025
| @@ -42,7 +41,7 @@ | |||
| class HalFormsAdaptingResponseBodyAdvice<T extends RepresentationModel<T>> | |||
| implements ResponseBodyAdvice<RepresentationModel<T>> { | |||
|
|
|||
| private static final Logger logger = LoggerFactory.getLogger(RequestResponseBodyMethodProcessor.class); | |||
| private static final Logger logger = LoggerFactory.getLogger(HalFormsAdaptingResponseBodyAdvice.class); | |||
| @@ -47,7 +47,7 @@ class RepositoryRestExceptionHandlerUnitTests { | |||
| @BeforeAll | |||
| public static void silenceLog() { | |||
|
|
|||
| logger = (Logger) LoggerFactory.getLogger(RepositoryRestExceptionHandler.class); | |||
| logger = (Logger) LoggerFactory.getLogger(RepositoryRestExceptionHandlerUnitTests.class); | |||
There was a problem hiding this comment.
This one is not useful as it accomplishes something else. The recipe would benefit from considering tests and where (method or class body) the logger is actually obtained.
odrotbohm
pushed a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: Moderne <[email protected]> Fixes GH-2479.
odrotbohm
pushed a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: Moderne <[email protected]> Fixes GH-2479.
odrotbohm
pushed a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: Moderne <[email protected]> Fixes GH-2479.
odrotbohm
changed the title
HalFormsAdaptingResponseBodyAdvice
|
I've partially applied the changes in the PR. As Mark pointed out, generally assuming you'd always want to obtain a logger for the same class might not hold true in edge cases, such as the one in our tests here. Thanks, nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hope this helps :)
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.logging.slf4j.LoggersNamedForEnclosingClass?organizationId=U3ByaW5n