DATAREST-994 - Fixed two argument constructor of RepositoryRestHandlerMapping #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
force-pushed
the
DATAREST-994
branch
from
d622ff0 to
3715b1c
Compare
mp911de
approved these changes
Feb 2, 2017
| @@ -82,6 +86,22 @@ public void createConfigurationShouldConstructFullCorsConfiguration() { | |||
| assertThat(configuration.getMaxAge(), is(1234L)); | |||
| } | |||
|
|
|||
|
|
|||
odrotbohm
requested changes
Feb 2, 2017
| @@ -266,14 +266,14 @@ public String resolveStringValue(String value) { | |||
| static class RepositoryCorsConfigurationAccessor { | |||
|
|
|||
| private final @NonNull ResourceMappings mappings; | |||
| private final @NonNull Repositories repositories; | |||
| private final Repositories repositories; | |||
| private final @NonNull StringValueResolver embeddedValueResolver; | |||
There was a problem hiding this comment.
Let's change the order (StringValueResolver before Repositories) so that we also have the constructor taking all non-null properties first.
schauder
force-pushed
the
DATAREST-994
branch
from
3e5f4bd to
e580c04
Compare
…rMapping. Repositories in RepositoryCorsConfigurationAccessor may be null now. findCorsConfiguration returns null when no repositories are provided. Original pull request: #257.
schauder
force-pushed
the
DATAREST-994
branch
from
e580c04 to
d954b46
Compare
schauder
added a commit
that referenced
this pull request
Feb 3, 2017
…rMapping. Repositories in RepositoryCorsConfigurationAccessor may be null now. findCorsConfiguration returns null when no repositories are provided. Original pull request: #257.
schauder
added a commit
that referenced
this pull request
Feb 3, 2017
…rMapping. Repositories in RepositoryCorsConfigurationAccessor may be null now. findCorsConfiguration returns null when no repositories are provided. Original pull request: #257.
schauder
added a commit
that referenced
this pull request
Feb 3, 2017
…rMapping. Repositories in RepositoryCorsConfigurationAccessor may be null now. findCorsConfiguration returns null when no repositories are provided. Original pull request: #257.
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repositories in RepositoryCorsConfigurationAccessor may be null now. findCorsConfiguration returns null when no repositories are provided.