Component scanning doesn't find enums in annotations [SPR-5479]

[spring-projects-issues]

Jon Bass opened SPR-5479 and commented

If I have an annotation like:
public @interface Foo {
String value();
Thread.State state() default Thread.State.WAITING;
}

Then the attributes in the AnnotatedBeanDefinition.getMetaData().getAnnotationattributes() always has the default value when I try to get them from a custom bean name generator.

---

Affects: 2.5.6

Issue Links:

• Regression: AnnotationMetadataReadingVisitor doesn't consider annotation method returning classes (SPR-5477) [SPR-5827] #10497 Regression: AnnotationMetadataReadingVisitor doesn't consider annotation method returning classes (SPR-5477)

Referenced from: commits 213b528

1 votes, 4 watchers

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out! Fixed in 3.0 M2 through explicitly detecting enum references and resolving them to their corresponding Java enum values.

Juergen

[spring-projects-issues]

Yong Qu commented

Hi, Juergen

Does it support visiting annotations that are Enum arrays?

I took a look at the class AnnotationAttributesReadingVisitor in trunk.

The method

public void visitEnum(String name, String desc, String value)

inside

public AnnotationVisitor visitArray(final String attrName)

is empty.

I copied following lines into that method and it is now able to read Enum array annotations.

public AnnotationVisitor visitArray(final String attrName) {
    return new AnnotationVisitor() {
        public void visit(String name, Object value) {
            Object newValue = value;
            Object existingValue = localAttributes.get(attrName);
            if (existingValue != null) {
                newValue = ObjectUtils.addObjectToArray((Object[]) existingValue, newValue);
            }
            else {
                Object[] newArray = (Object[]) Array.newInstance(newValue.getClass(), 1);
                newArray[0] = newValue;
                newValue = newArray;
            }
            localAttributes.put(attrName, newValue);
        }
        public void visitEnum(String name, String desc, String value) {
            Object valueToUse = value;
            try {
                Class<?> enumType = classLoader.loadClass(Type.getType(desc).getClassName());
                Field enumConstant = ReflectionUtils.findField(enumType, value);
                if (enumConstant != null) {
                    valueToUse = enumConstant.get(null);
                }
            }
            catch (Exception ex) {
                // Class not found - can't resolve class reference in annotation attribute.
            }
            
            Object newValue = valueToUse;
            
            Object existingValue = localAttributes.get(attrName);
            if (existingValue != null) {
                newValue = ObjectUtils.addObjectToArray((Object[]) existingValue, newValue);
            }
            else {
                Object[] newArray = (Object[]) Array.newInstance(newValue.getClass(), 1);
                newArray[0] = newValue;
                newValue = newArray;
            }
            localAttributes.put(attrName, newValue);
        }
        public AnnotationVisitor visitAnnotation(String name, String desc) {
            return new EmptyVisitor();
        }
        public AnnotationVisitor visitArray(String name) {
            return new EmptyVisitor();
        }
        public void visitEnd() {
        }
    };
}

Thanks!

Yong

[spring-projects-issues]

Marc Vanbrabant commented

We have a custom annotation with an Enum array in it.

@SpecialController( { Some.ENUM, Some.OtherENUM } )

When using a custom TypeFilter I found out that the enum values are always the default values. I went to check the source code and saw that I seem to be facing the same problem as in this issue here. The:

public void visitEnum(String name, String desc, String value) method inside the :
public AnnotationVisitor visitArray(final String attrName)

is empty. We are on 3.0.5, but I saw that the 3.1.0 M1 (see https://src.springsource.org/svn/spring-framework/tags/spring-framework-3.1.0.M1/org.springframework.core/src/main/java/org/springframework/core/type/classreading/AnnotationAttributesReadingVisitor.java) also has this issue. Is this a regression?

[spring-projects-issues]

Juergen Hoeller commented

Closing groups of outdated issues. Please reopen if still relevant.