ClassPathBeanDefinitionScanner vs ClassPathBeanDefinitionScanner: difference in behavior when dealing with @ComponentScan excludeFilters [SPR-9100]

[spring-projects-issues]

Yannick Lazzari opened SPR-9100 and commented

There seems to be a difference in the way configuration classes, i.e. classes annotated with @Configuration, are handled by the ClassPathBeanDefinitionScanner vs the AnnotatedBeanDefinitionReader. The javadoc says that the AnnotatedBeanDefinitionReader is, "...an alternative to ClassPathBeanDefinitionScanner, applying the same resolution of annotations but for explicitly registered classes only.". If you read the Spring forum thread attached to this issue report, you will find an example that shows that the way @ComponentScan excludeFilters are processed is not the same; actually, they seemed to be totally ignored when the ClassPathBeanDefinitionScanner scans a class annotated in the following manner:

@Configuration
@ComponentScan(basePackages={"com.foo", "com.bar"}, excludeFilters={@ComponentScan.Filter(type = FilterType.ASSIGNABLE_TYPE, value = com.foo.ComponentA.class)})
public class TestConfig {
}

---

Affects: 3.1 GA

Reference URL: http://forum.springsource.org/showthread.php?122907-Spring-3-1-AnnotationConfigWebApplicationContext-scan-vs-register-method&p=400832

Issue Links:

• @ComponentScan with includeFilters on @Import-ed context does not work [SPR-9031] #13670 @ComponentScan with includeFilters on @Import-ed context does not work ("duplicates")
• @ComponentScan does not work when referenced from XML config [SPR-7979] #12634 @ComponentScan does not work when referenced from XML config
• @ComponentScan(includeFilters=@Filter(...)) fails when @Import'ed [SPR-8719] #13361 @ComponentScan(includeFilters=@Filter(...)) fails when @Import'ed

[spring-projects-issues]

Chris Beams commented

Hi Yannick,

You're in luck -- this issue is already fixed with #13670. You can try it out in 3.1.1.BUILD-SNAPSHOT, but also note that we'll release 3.1.1 quite shortly anyway.

See the resolution comment there for complete details on why this was occurring, if you're interested.

[spring-projects-issues]

Anderson Vaz commented

Hi Chris,

I'm using version 3.1.1 but seems that this problem ain't really go away. See the case bellow:

My tests context config is class based:
@Configuration
@ComponentScan(value={"com.acme"},
excludeFilters={@ComponentScan.Filter(value=NoteController.class,
type= FilterType.ASSIGNABLE_TYPE )} )
public class AcmeTestConfig {
//Mock objects
@Bean
public NoteController noteController() {
NoteController noteController = Mockito.mock( NoteController.class );
return noteController;
}
}

And two beans in the package "com.acme.controller":

@Controller
@Transactional
public class TaskController {
@Autowired
private NoteController noteController;
}

@Controller
public class NoteController {
}

The problem is if a use the package "com.acme" for the value of @ComponentScan the excludeFilter property doesn't work, the class NoteController is not excluded from de scan, but if a use "com.acme.controller" the excludeFilter work and the class NoteController is excluded from the scan. I suppose that the excludeFilter needs to work on both type of package declaration.
Is this correct?

Regards!

[spring-projects-issues]

Chris Beams commented

Anderson,

Please follow the instructions at https://github.com/SpringSource/spring-framework-issues#readme to submit a simple reproduction of this problem, and also open a new JIRA issue so that we don't lose track of this.

Thanks!