MutablePropertySources#get throws when it should return null [SPR-9179]

[spring-projects-issues]

Frank Scheffler opened SPR-9179 and commented

Using contains() to check in advance is a valid work-around, but the JavaDoc should not state returning null, if throwing NPE.

---

Affects: 3.1 GA

Sub-tasks:

• Backport "MutablePropertySources#get throws when it should return null" [SPR-9185] #13823 Backport "MutablePropertySources#get throws when it should return null"

Referenced from: commits 7d72ab5, 15d1d82

[spring-projects-issues]

Chris Beams commented

Thanks, Frank.

You originally mentioned an NPE being thrown; I'm not seeing where this could happen, but I have fixed the following in the meantime. I assume this was just a typo on your part, but please let me know if there's some other issue you're seeing.

commit 15d1d824b54b2ec36a7c926e12644b391b310930
Author: Chris Beams <cbeams@vmware.com>
Date:   Wed Feb 29 14:29:13 2012 +0100

    Return null correctly from MutablePropertySources#get
    
    Prior to this commit, MutablePropertySources#get(String) would throw
    IndexArrayOutOfBoundsException if the named property source does not
    actually exist. This is a violation of the PropertySource#get contract
    as described in its Javadoc.
    
    The implementation now correctly checks for the existence of the named
    property source, returning null if non-existent and otherwise returning
    the associated PropertySource.
    
    Other changes
    
     - Rename PropertySourcesTests => MutablePropertySourcesTests
     - Polish MutablePropertySourcesTests for style, formatting
     - Refactor MutablePropertySources for consistency
    
    Issue: SPR-9179

[spring-projects-issues]

Frank Scheffler commented

My fault: This was exactly what I meant, IndexArrayOutOfBounds instead of NPE.