DispatcherPortlet shouldn't call exposeActionException during event processing [SPR-9287]

[spring-projects-issues]

Eric Dalquist opened SPR-9287 and commented

DispatcherPortlet.doEventService calls exposeActionException if an exception is thrown during event processing. The intent is to show the exception the next time the portlet renders.

The problem is a portlet that is handling an event may never render again. This approach of swallowing the exception results in the exception being hidden from the portlet container and no mention of the exception appearing anywhere unless DEBUG logging is enabled in the afflicted portlet.

I believe that exposeActionException should be removed for event requests and made optional for action requests to allow portlets to rely on the container provided exception handling.

---

Affects: 3.0.7, 3.1.1

Sub-tasks:

• Backport "DispatcherPortlet shouldn't call exposeActionException during event processing" [SPR-9555] #14189 Backport "DispatcherPortlet shouldn't call exposeActionException during event processing"

Referenced from: commits 5965710, 79b86a7

1 votes, 3 watchers

[spring-projects-issues]

Eric Dalquist commented

#103

[spring-projects-issues]

Juergen Hoeller commented

DispatcherPortlet does not forward event exceptions to the render phase by default now. This can be configured through the new "forwardEventException" property (= servlet init-param) on DispatcherPortlet. Similarly, "forwardActionException" allows to turn off action exception forwarding if desired. This will also be backported to 3.1.2.

Eric, note that I've renamed the properties to be more meaningful to the DispatcherServlet user (since 'exposing' is really just an internal step there). Other than that, the changes are very close to your patch.

Juergen