Backport "Address various ExtendedBeanInfo bugs" [SPR-9778]

[spring-projects-issues]

Chris Beams opened SPR-9778 and commented

---

Affects: 3.1.1

This issue is a backport sub-task of #14050

Referenced from: commits 30d0bd3

1 votes, 3 watchers

[spring-projects-issues]

Donnchadh O Donnabhain commented

Please let us know when there is a snapshot build available with this fix as I would like to test it. #14050 in 3.2M2 seems fine but I'd still like to test with a 3.1.3 snapshot before 3.1.3 is released.

[spring-projects-issues]

Chris Beams commented

Thanks, Donnchadh. I'll prioritize this, then, and let you know.

[spring-projects-issues]

Chris Beams commented

This is complete, Donnchadh. https://build.springsource.org/browse/SPR-B31X-150 is producing the snapshot now. We're planning to ship 3.1.3 this weekend, we hope you can give the changes a spin before then. Thanks!

commit 30d0bd309cfb707813537751db431a3f56212d2b
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Address various ExtendedBeanInfo bugs
    
     - Ensure that ExtendedBeanInfoTests succeeds when building under JDK 7
    
     - Improve handling of read and write method registration where
       generic interfaces are involved, per SPR-9453
    
     - Add repro test for SPR-9702, in which EBI fails to register
       an indexed read method under certain circumstances
    
    Issue: SPR-9778
    Backport-Issue: SPR-9702, SPR-9414, SPR-9453
    Backport-Commit: b50bb5071ac353e77e9d38c72f888de3add923b2

commit e70119733a9e7804d4e546b6b74933c7c48151df
Author: Chris Beams <cbeams@vmware.com>
Commit: Chris Beams <cbeams@vmware.com>

    Avoid further 'type mismatch' errors in ExtendedBeanInfo
    
    This change fixes further cases under JDK 6 in which setting a bridged
    (e.g. String-returning) read method can conflict with an existing
    corresponding bridge write method that accepts an Object parameter.
    
    This appears to be a implementation difference between JDKs 6 and 7,
    where the JDK 6 Introspector adds bridge methods and JDK 7 does not.
    
    The solution here is to consistently null-out any existing write method
    before setting the read method. We were doing this elsewhere in
    ExtendedBeanInfo already, but these two changes make the approach
    consistent throuhout.
    
    Issue: SPR-8806
    Backport-Commit: 0c0a563a241466813ccc8233195e35bfee369920

[spring-projects-issues]

Donnchadh O Donnabhain commented

That's great. It seems fine on both Java 6 (1.6.0_35) and Java 7 (1.7.0_07).

[spring-projects-issues]

Chris Beams commented

Excellent! Thanks for the quick feedback.