Fix package cycles in spring-test [SPR-9924]

[spring-projects-issues]

Chris Beams opened SPR-9924 and commented

Sam Brannen, see attached screenshots from Structure 101 - it looks like a couple package cycles crept in during recent changes to spring-test. /cc Rossen Stoyanchev

---

Affects: 3.2 RC1

Attachments:

• Screen Shot 2012-10-26 at 2.20.23 PM.png (49.87 kB)
• Screen Shot 2012-10-26 at 2.20.47 PM.png (53.95 kB)
• Screen Shot 2012-10-27 at 9.12.33 PM.png (118.38 kB)

Issue Links:

• Introduce bootstrap strategy in the TestContext framework [SPR-9955] #14588 Introduce bootstrap strategy in the TestContext framework

Referenced from: commits 461d99a, 90c5f22, a281bdb

[spring-projects-issues]

Sam Brannen commented

Completed as described in the comments for GitHub commit 90c5f226b6:

Fix package cycles in spring-test

Code introduced in conjunction with #9917 introduced package cycles
between the ~.test.context.web and ~.test.context.support packages. This
was caused by the fact that ServletTestExecutionListener extended
AbstractTestExecutionListener.

To address this, ServletTestExecutionListener now implements
TestExecutionListener directly.

[spring-projects-issues]

Chris Beams commented

Hi Sam,

Some tangles have indeed been resolved, but it looks like one remains. See the screenshot, thanks.

[spring-projects-issues]

Sam Brannen commented

Completed as described in the comments for GitHub commit 461d99af29:

Fix package cycles in spring-test

Code introduced in conjunction with #9917 introduced package cycles
between the ~.test.context and ~.test.context.web packages. This was
caused by the fact that ContextLoaderUtils worked directly with the
@WebAppConfiguration and WebMergedContextConfiguration types.

To address this, the following methods have been introduced in
ContextLoaderUtils. These methods use reflection to circumvent hard
dependencies on the @WebAppConfiguration and
WebMergedContextConfiguration types.

• loadWebAppConfigurationClass()
• buildWebMergedContextConfiguration()