Skip to content

ServletUriComponentsBuilder doesn't work if X-Forwarded-Host is in host:port format [SPR-10701] #15329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jun 27, 2013 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jun 27, 2013

Hrvoje Jambrovic opened SPR-10701 and commented

Linked with #14743
ServletUriComponentsBuilder takes X-Forwarded-Host value from header (if exists) and puts it as "host".
If X-Forwarded-Host is:
X-Forwarded-Host: webtest.foo.bar.com:443

creating uri produces error:

org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.IllegalStateException: Could not create URI object: Malformed IPv6 address at index 8: http://[webtest.foo.bar.com:443]:8180/api/person/449089
at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:948)
...

Definition of Host header:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.23

X-Forwarded-Host is a copy of Host header:
http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#x-headers


Affects: 3.2.1

Issue Links:

Referenced from: commits 1e90d02, 6c11fd3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants