ScriptExecutor for JSR-223 [SPR-11007]

[spring-projects-issues]

Mark Pollack opened SPR-11007 and commented

Several projects, SI, Security and Spring Hadoop have code that evaluates a groovy script. The Spring Hadoop project has

https://github.com/spring-projects/spring-hadoop/blob/master/spring-hadoop-core/src/main/java/org/springframework/data/hadoop/scripting/Jsr223ScriptEvaluator.java

and SI has

https://github.com/spring-projects/spring-integration/blob/master/spring-integration-groovy/src/main/java/org/springframework/integration/groovy/GroovyScriptExecutingMessageProcessor.java

In the SI case it doesn't use JSR233 infrastructure to invoke the script, but Groovy support classes. Artem mentioned that using the groovy support classes might result is a faster overall script execution time, so that should be investigated.

The running suggestion is to incorporate the JSR223ScrfiptEvaluator functionality as it provides support for a wider range of scripting languages out of the box.

---

Issue Links:

• XD-1027 Create script-based batch ItemProcessor ("is depended on by")
• ScriptFactory for JSR-223 [SPR-5215] #9888 ScriptFactory for JSR-223
• Allow specifying CompilationCustomizer for Groovy based beans [SPR-14585] #19154 Allow specifying CompilationCustomizer for Groovy based beans

Referenced from: commits dfb29f4

[spring-projects-issues]

Gary Russell commented

Heads-up: we have an open SI PR for some performance improvements to the GroovyScriptExecutingMessageProcessor spring-projects/spring-integration#915 (avoiding unnecessary synchronization). It's been through review; I haven't gotten around to merging it yet, I just need to give it one more quick once-over; I will try to get to it over the weekend.

spring-projects/spring-integration#915

We also recently merged a couple of fixes to the jsr223 support in SI... https://github.com/spring-projects/spring-integration/commits/master/spring-integration-scripting - a problem with thread-safety, and fixing the refresh mechanism.

[spring-projects-issues]

Mark Pollack commented

Oh, I wasn't aware of spring-integration-scripting. That looks quite nice.

[spring-projects-issues]

Artem Bilan commented

Hi there!

using the groovy support classes might result is a faster overall script execution time, so that should be investigated.

Mark Pollack, here is a performance test case: https://gist.github.com/artembilan/7072431.
Of course, it's not up to this issue.
It shows the time of Groovy script execution of our (SI) new GroovyScriptExecutingMessageProcessor (spring-projects/spring-integration#915) as compared with JSR223 ScriptExecutingMessageProcessor.
Note, changing the order of processors in the MESSAGE_PROCESSORS shows the same 'Warm-up' time (percents): looks like it's up to some internal Groovy infrastructure first time initialization, who, of course, is used by both (direct Groovy & jsr223) engines.
Similar results we get with RefreshableResourceScriptSource (refreshable and not).

Cheers

[spring-projects-issues]

Juergen Hoeller commented

I've introduced the ScriptEvaluator strategy interface in org.springframework.scripting now, including implementations for JSR-223 (called StandardScriptEvaluator), Groovy and BeanShell.

StandardScriptEvaluator still has a language property but can also infer the file extension from the original filename in case of a ResourceScriptSource.

GroovyScriptEvaluator exposes additional context such as the original filename which Groovy uses to generate its script name at runtime.

While being at it, I've also revised ScriptFactory and its implementations for varargs, as a general overhaul of the scripting package.

Juergen