Downgrade accidental use of Java 1.7 APIs [SPR-11319]

[spring-projects-issues]

Stéphane Nicoll opened SPR-11319 and commented

To prevent issue similar to #15937 we have integrated animal sniffer in our build to check the use of the JDK APIs.

This issue is about collecting the classes that are using 1.7+ APIs, knowing that some are for perfectly valid reasons (support of 1.8 features)

---

Issue Links:

• spring-jdbc-3.2.6.RELEASE doesn't support JDK 5. [SPR-11313] #15937 spring-jdbc-3.2.6.RELEASE doesn't support JDK 5.
• UriComponentsBuilder - NoSuchMethodError: java.lang.reflect.Method.getParameterCount [SPR-11245] #15870 UriComponentsBuilder - NoSuchMethodError: java.lang.reflect.Method.getParameterCount
• Support BigDecimals with SpEL [SPR-9164] #13802 Support BigDecimals with SpEL
• Downgrade accidental use of Java 1.6 APIs [SPR-11321] #15945 Downgrade accidental use of Java 1.6 APIs

Referenced from: commits 838855b

[spring-projects-issues]

Stéphane Nicoll commented

StandardTypeComparator (due to #13802)

[spring-projects-issues]

Stéphane Nicoll commented

snicoll@6d1c215 fixes the only accidental use of the Java 1.7 APIs.

Juergen can you please review and cherry pick it? Thanks!

[spring-projects-issues]

Stéphane Nicoll commented

Juergen, as you're working on that, I'll assign it to you.

Thanks

[spring-projects-issues]

Juergen Hoeller commented

Fixed along with a general revision of StandardTypeComparator.

As a reminder for casual readers: For some reason, Integer.compare and Long.compare have been introduced as late as JDK 1.7, even if their Float and Double counterparts have been available for much longer.

Since all that those compare methods do is to calculate a comparison result based on primitive values, it's straightforward to implement equivalent behavior:

private static int compare(int x, int y) {
return (x < y ? -1 : (x > y ? 1 : 0));
}

private static int compare(long x, long y) {
return (x < y ? -1 : (x > y ? 1 : 0));
}

Juergen