CacheAspectSupport 's generateKey method should not concatenate Strings [SPR-12527]

[spring-projects-issues]

Kyrill Alyoshin opened SPR-12527 and commented

CacheAspectSupport class has the following line of code at the beginning of its generateKey method:

Assert.notNull(key, "Null key returned for cache operation (maybe you are using named params " +
				"on classes without debug info?) " + context.operation);

YourKit shows that this single method call takes about 15% of total time when invoking a "cached" method through Spring caching pipeline. It is not surprising because context.operation object has a non-trivial implementation of the toString method.

We really think that this Assert.notNull call should be refactored into if(key == null)... for performance reasons.

---

Affects: 4.1.3

Referenced from: commits 67f1842

Backported to: 4.0.9

1 votes, 3 watchers

[spring-projects-issues]

Stéphane Nicoll commented

Good catch, most of the logging usage of CacheOperation are guarded by logger.isTraceEnabled - This may also be a nice improvements for Spring 4.0.x (that piece of code of yours is coming from 4.0.x I think)

[spring-projects-issues]

Stéphane Nicoll commented

Fixed.

Juergen Hoeller, I think that's a good candidate for a backport. What do you think?