Skip to content

Replace ParsingPathMatcher with PathPattern registry [SPR-15608] #20167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Jun 1, 2017 · 0 comments
Closed
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jun 1, 2017

Brian Clozel opened SPR-15608 and commented

Now that PathPattern has been introduced, further changes can be applied to spring-webflux to simplify the routing algorithm.

Instead of relying on the ParsingPathMatcher and managing String instances, we could:

  • AbstractHandlerMapping and subclasses should use PathPattern instances and a private registry instead of String and PathMatcher
  • The PatternsRequestCondition should also keep an ordered collection of PathPattern and use a PathPatternParser, in order to replace String and PathMatcher

Other possible improvements:


Issue Links:

Referenced from: commits 233c15b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants