Skip to content

Error signal not propagated if writeFunction in ChannelSendOperator fails immediately #23175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rstoyanchev opened this issue Jun 21, 2019 · 0 comments
Assignees
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

If the writeFunction in ChannelSendOperator fails immediately inside the call to apply, the error signal should be propagated to the write completion Subscriber. Not doing so means the error is lost and the write appears to never complete.

This is unlikely to occur in WebFlux unless one of the Supplier based commit action fails, but is more likely to happen in RSocket processing where the write function invokes a return value handler (and is how it was uncovered).

@rstoyanchev rstoyanchev added in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement labels Jun 21, 2019
@rstoyanchev rstoyanchev added this to the 5.1.9 milestone Jun 21, 2019
@rstoyanchev rstoyanchev self-assigned this Jun 21, 2019
rstoyanchev added a commit that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging Issues in messaging modules (jms, messaging) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant