Retain merged bean definition caches during post processing #23336
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: enhancement
A general enhancement
Milestone
Comments
philwebb
added
in: core
6 tasks
philwebb
added a commit
to philwebb/spring-framework
that referenced
this issue
Jul 23, 2019
Update the logic in `AbstractBeanFactory` so that caches from merged bean definitions remain whenever possible. Prior to this commit, all merged bean definitions would be completely removed after bean post processing in case a processor changed the bean type. It's fairly unlikely these days that the bean type will actually change, so instead we now compare a subset of the old cached properties against the newly created definition. Only if key properties have changed do we now discard the older cached values. Closes spring-projectsgh-23336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the
RootBeanDefinitionused to represent merged bean definitions includes quite a few package private caches. These are currently dropped whenever after bean post processors have run in case post processing causes the bean type to change. In modern Spring applications this is very unlikely to happen and we could benefit my trying to retain cached items if they're still relevant.The text was updated successfully, but these errors were encountered: