Deprecate/Remove internal APIs in ScriptUtils implementations #26947
Assignees
Labels
in: data
Issues in data modules (jdbc, orm, oxm, tx)
status: backported
An issue that has been backported to maintenance branches
type: enhancement
A general enhancement
Milestone
Comments
sbrannen
added
in: data
spring-projects-issues
added
status: backported
sbrannen
added a commit
that referenced
this issue
May 17, 2021
Prior to this commit, many of the utility methods in ScriptUtils in spring-r2dbc were public by accident: they were copied from ScriptUtils in spring-jdbc without changing the visibility when spring-r2dbc was introduced in Spring Framework. 5.3 GA. This commit corrects this mistake by removing internal APIs from ScriptUtils in spring-r2dbc from the public contract. See gh-26947
sbrannen
changed the title
sbrannen
added a commit
that referenced
this issue
May 17, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
May 18, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
May 18, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
May 18, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
May 18, 2021
Many of the utility methods in ScriptUtils are public only because they were once invoked from JdbdTestUtils in spring-test, which is no longer the case. Consequently, there should no longer be a need for any external clients to invoke such methods. To address, this commit formally deprecates the following methods in ScriptUtils in spring-jdbc. - readScript(...) - containsSqlScriptDelimiters(...) - splitSqlScript(...) Closes spring-projectsgh-26947
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Prior to this commit, many of the utility methods in ScriptUtils in spring-r2dbc were public by accident: they were copied from ScriptUtils in spring-jdbc without changing the visibility when spring-r2dbc was introduced in Spring Framework. 5.3 GA. This commit corrects this mistake by removing internal APIs from ScriptUtils in spring-r2dbc from the public contract. See spring-projectsgh-26947
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Many of the utility methods in ScriptUtils are public only because they were once invoked from JdbdTestUtils in spring-test, which is no longer the case. Consequently, there should no longer be a need for any external clients to invoke such methods. To address this, this commit formally deprecates the following methods in ScriptUtils in spring-jdbc. - readScript(...) - containsSqlScriptDelimiters(...) - splitSqlScript(...) Closes spring-projectsgh-26947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview
Various utility methods in the
ScriptUtilsimplementations inspring-jdbcandspring-r2dbcarepublicbut should not be since they are effectively internal APIs that no external client should call.Public due to historical reasons in
spring-jdbcSome of these utility methods are public because of historical reasons -- for example, many of the public methods in
ScriptUtilsinspring-jdbcare only public because they were once invoked fromJdbdTestUtilsinspring-test, which is no longer the case.Public by accident in
spring-r2dbcSome of these utility methods are public by accident -- for example, many of the public methods in
ScriptUtilsinspring-r2dbcare only public because they were copied fromScriptUtilsinspring-jdbcwithout changing the visibility.Methods to deprecate
splitSqlScript(...)readScript(...)containsSqlScriptDelimiters()The text was updated successfully, but these errors were encountered: