Skip to content

Upgrade to spring-javaformat-checkstyle 0.0.28 and downgrade to Checkstyle 8.41 #27481

@sbrannen

Description

@sbrannen
Member

In order to be able to use text blocks and other new Java language features, we should upgrade to a recent version of Checkstyle.

The latest version of spring-javaformat-checkstyle (0.0.28) is built against Checkstyle 8.32 which does not include support for language features such as text blocks. Support for text blocks was added in Checkstyle 8.36.

In addition, there is a binary compatibility issue between spring-javaformat-checkstyle 0.0.28 and Checkstyle 8.42.

Thus we cannot use Checkstyle 8.45.1.

We therefore need to upgrade to spring-javaformat-checkstyle 0.0.28 and downgrade to Checkstyle 8.41.

This change will be applied to 5.3.x as well as main in order to benefit from the enhanced checking provided in more recent versions of Checkstyle.

Activity

added this to the 5.3.11 milestone on Sep 28, 2021
self-assigned this
on Sep 28, 2021
added a commit that references this issue on Sep 28, 2021
2567b20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @sbrannen

      Issue actions

        Upgrade to spring-javaformat-checkstyle 0.0.28 and downgrade to Checkstyle 8.41 · Issue #27481 · spring-projects/spring-framework