Skip to content

BeanPropertyRowMapper underscoreName prepends redundant underscore when field descriptor begins in uppercase #27929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patrickabner opened this issue Jan 13, 2022 · 1 comment
Closed

BeanPropertyRowMapper underscoreName prepends redundant underscore when field descriptor begins in uppercase #27929

patrickabner opened this issue Jan 13, 2022 · 1 comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: regression A bug that is also a regression

Comments

@patrickabner
Copy link

When pojo contains eMail field and Lombok generates setEMail accessor, then BeanPropertyRowMappers underscoreName is _e_mail, which breaks database integration. Symptom appeared with Spring 5.3 from commit 6316a35
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 13, 2022
@sbrannen sbrannen added in: data Issues in data modules (jdbc, orm, oxm, tx) type: regression A bug that is also a regression labels Jan 13, 2022
@sbrannen sbrannen added this to the Triage Queue milestone Jan 13, 2022
mdeinum added a commit to mdeinum/spring-framework that referenced this issue Jan 17, 2022
@mdeinum
Fix regression with underscore name
db57be2 
With 6316a35 I introduced a regression for fields starting
with an uppercase letter. This commit fixes that regression
including an additional test to cover this case.

Fixes: spring-projectsgh-27929
@mdeinum mdeinum mentioned this issue Jan 17, 2022
Closed
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 17, 2022
@sbrannen sbrannen self-assigned this Jan 17, 2022
@sbrannen sbrannen modified the milestones: Triage Queue, 5.3.16 Jan 17, 2022
@sbrannen
Copy link
Member

Superseded by PR #27941

@sbrannen sbrannen added the status: superseded An issue that has been superseded by another label Jan 17, 2022
@sbrannen sbrannen removed their assignment Jan 17, 2022
@snicoll snicoll closed this as completed Jan 17, 2022
sbrannen pushed a commit that referenced this issue Jan 17, 2022
@mdeinum @sbrannen
Fix regression in BeanPropertyRowMapper.underscoreName(String)
261bc2a 
Commit 6316a35 introduced a regression for property names starting with
multiple uppercase letters (such as setEMail(...)).

This commit fixes that regression and includes an additional test to
cover this case.

See gh-27929
Closes gh-27941
sbrannen added a commit that referenced this issue Jan 17, 2022
@sbrannen
Explicitly test BeanPropertyRowMapper.underscoreName(String)
420c4f3 
See gh-27929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: regression A bug that is also a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression in BeanPropertyRowMapper regarding underscore name mdeinum/spring-framework
4 participants
@sbrannen @snicoll @spring-projects-issues @patrickabner