PathMatchingResourcePatternResolver support for URL-protocol "wsjar" [SPR-1631]

[spring-projects-issues]

Leif John Korshavn opened SPR-1631 and commented

My project wanted to use PathMatchingResourcePatternResolver to find certain xml-files in the classpath. Everything worked just fine for both file-system and jar-files until we deployed the application on WebSphere. Turns out WAS returns from URL.getProtocol() the string "wsjar" for jar-files (bundled in ear).

This makes the PathMatchingResourcePatternResolver treat the wsjar-entry like a file-system file, which is not, of course leading to the error:

Caused by: java.io.FileNotFoundException: URL [wsjar:file:/C:/IBM/WebSphere/AppServer/profiles/devel/installedApps/XPPC2270Node01Cell/nics-core.ear/nics-core-SNAPSHOT.jar!/typeresolver/] cannot be resolved to absolute file path because it does not reside in the file system: wsjar:file:/C:/IBM/WebSphere/AppServer/profiles/devel/installedApps/XPPC2270Node01Cell/nics-core.ear/nics-core-SNAPSHOT.jar!/typeresolver/
at org.springframework.util.ResourceUtils.getFile(ResourceUtils.java:173)
at org.springframework.core.io.UrlResource.getFile(UrlResource.java:118)
at org.springframework.core.io.support.PathMatchingResourcePatternResolver.doFindPathMatchingFileResources(PathMatchingResourcePatternResolver.java:382)
at org.springframework.core.io.support.PathMatchingResourcePatternResolver.findPathMatchingResources(PathMatchingResourcePatternResolver.java:265)
at org.springframework.core.io.support.PathMatchingResourcePatternResolver.getResources(PathMatchingResourcePatternResolver.java:202)
at no.bbs.common.type.TypeResolver.<clinit>(TypeResolver.java:35)
... 69 more

I could find no documentation anywhere as to what makes "wsjar" differ from "jar".

My workaround is to implement the classpath-search myself, treating "wsjar" like "jar.
But I would very much appreciate support for IBM¨'s url-protocol wsjar.

Best regards!

---

Affects: 1.2.6

[spring-projects-issues]

Juergen Hoeller commented

Thanks for pointing this out! I've addressed this through refining PathMatchingResourcePatternResolver's "isJarResource" implementation, to not only check against URL protocol "jar" and "zip" but also "wsjar" now. If, as you say, that protocol can be treated just like a jar file, this should do the job.

Please try to patch this locally in your PathMatchingResourcePatternResolver.java (and rebuild Spring through "build alljars" in the root of the distribution):

protected boolean isJarResource(Resource resource) throws IOException {
String protocol = resource.getURL().getProtocol();
return (URL_PROTOCOL_JAR.equals(protocol) ||
URL_PROTOCOL_ZIP.equals(protocol) ||
"wsjar".equals(protocol));
}

Let me know whether this works for you!

Alternatively, you could also give one of the next nightly Spring 2.0 snapshots a try.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

Have you already had a chance to verify whether such a plain "wsjar" check in PathMatchingResourcePatternResolver's "isJarResource" method works?

Juergen

[spring-projects-issues]

Juergen Hoeller commented

I consider this as fixed for the time being. To be reopened if any further issues arise.

Juergen

[spring-projects-issues]

Leif John Korshavn commented

Thanks!

I apologize for not being able to answer earlier. In fact, I didn't even expect this quick response from you on this problem, as it was a minor problem. (If I knew you'd respond this fast, I wouldn't have spent time implementing my workaround :-)

I have made the patch you suggested and tested it, and it does the trick. I have no problem with wsjar now with PathMatchingResourcePatternResolver.

Thanks!!

---

Leif John