Fixed #DATAREDIS-527 Added ErrorHandler to the AspectjCachingConfiguration #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, have you signed the CLA? |
|
@snicoll Yes. |
|
@snicoll Thanks for the reply..I saw the contribution doc and signed that and updated the comment as wel. please let me know if anything I am missing. |
|
All good, thanks a lot! |
|
Thanks for the PR, I've fixed the issue in a larger revision adding missing tests in the process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling caching on aspectj mode, custom error handler was not getting inject.
Fix is to
set errorHandler on AspectJCachingConfiguration