Skip to content

Fix construction of NullSafeComparator in nullsLow #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

Homlet
Copy link
Contributor

@Homlet Homlet commented Oct 5, 2018

Previously, both nullsLow(Comparator) and nullsHigh(Comparator) returned a NullSafeComparator which treated nulls as being high. This commit corrects the typo in nullsLow.

Previously, both nullsLow(Comparator<T>) and
nullsHigh(Comparator<T>) returned a
NullSafeComparator which treated nulls as being
high. This commit corrects this typo.
@jhoeller jhoeller merged commit 80e7819 into spring-projects:master Oct 5, 2018
@jhoeller
Copy link
Contributor

jhoeller commented Oct 5, 2018

Good catch! Thanks for the pull request; I'll make sure to backport it to 5.0.10 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants