Support Optional<Principal> argument in @MessageMapping #23612
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method argument resolver to Optional<Principal> @MessageMapping can use Optional<Principal> as a method argument, which allows to work with or without authentication and to avoid error message org.springframework.messaging.simp.annotation.support.MissingSessionUserException: No "user" header in message
|
@KateVasovski Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@KateVasovski Thank you for signing the Contributor License Agreement! |
|
Thanks for the PR. I think this should be done in |
…possibility to resolve Optional<Principal>
rstoyanchev
added
in: messaging
rstoyanchev
changed the title
rstoyanchev
added a commit
that referenced
this pull request
Oct 23, 2019
|
This has been merged. I've squashed the commits into one. There is no reason for the prior incarnation to remain in history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method argument resolver to Optional
@MessageMapping can use Optional as a method argument, which allows to work with or without authentication and to avoid error message org.springframework.messaging.simp.annotation.support.MissingSessionUserException: No "user" header in message