Skip to content

fix issue #23939 #23950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix issue #23939 #23950

wants to merge 1 commit into from

Conversation

hicf
Copy link

@hicf hicf commented Nov 7, 2019

No description provided.

@pivotal-issuemaster
Copy link

@about-cloud Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 7, 2019
@pivotal-issuemaster
Copy link

@about-cloud Thank you for signing the Contributor License Agreement!

@sbrannen
Copy link
Member

Thanks for submitting the PR; however, I am closing it for the following reasons.

  1. The proposed change to StringToUUIDConverter is a breaking change that we cannot accept.
  2. The team has not yet decided what (if anything) will be done about the issues raised in Empty or blank required UUID header validation results in 200 response status #23939.

The team will further investigate options in the 5.3 time frame.

@sbrannen sbrannen closed this Nov 12, 2019
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 12, 2019
@sbrannen sbrannen changed the title fix issues#23939 fix issue #23939 Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants