Skip to content

Improve documentation for @Autowired/@Value in @Configuration classes #24585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

chenqimiao
Copy link
Contributor

@chenqimiao chenqimiao commented Feb 24, 2020

Original:
Otherwise, @Autowired and @Value do not work on the configuration class itself, since it is being created as a bean instance too early.

I think this statement is not accurate enough. @Autowired actually works, if the priority of the definition of BeanPostProcessor through @Bean lower than AutowiredAnnotationBeanPostProcessor.
So, I think we can adjust this description.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 24, 2020
@sbrannen sbrannen added type: documentation A documentation task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 25, 2020
@sbrannen sbrannen self-assigned this Feb 25, 2020
@sbrannen sbrannen added this to the 5.2.4 milestone Feb 25, 2020
@sbrannen sbrannen changed the title Make the document description of core-bean.adoc more accurate Improve documentation for @Autowired/@Value usage in @Configuration classes Feb 25, 2020
@sbrannen sbrannen changed the title Improve documentation for @Autowired/@Value usage in @Configuration classes Improve documentation for @Autowired/@Value in @Configuration classes Feb 25, 2020
@sbrannen sbrannen merged commit 8cf70fe into spring-projects:master Feb 25, 2020
@sbrannen
Copy link
Member

This has been merged into master.

Thanks

@chenqimiao chenqimiao deleted the polish-core-beans.adoc branch February 25, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants