fix for issue #25323 with test #25558
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eitan613 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@eitan613 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
reviewed
Aug 14, 2020
| URI checkUri = UriComponentsBuilder.fromUri(uri).build(true).toUri(); | ||
| assertThat(uri.toString()).isEqualTo(checkUri.toString()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Looks like you accidentally included this, which I recognize as a scenario from an unrelated issue.
rstoyanchev
reviewed
Aug 14, 2020
| @@ -440,7 +440,7 @@ public UriComponents build() { | |||
| /** | |||
| * Build a {@code UriComponents} instance from the various components | |||
| * contained in this builder. | |||
| * @param encoded whether all the components set in this builder are | |||
| * @param encoded asserts whether all the components set in this builder are already | |||
There was a problem hiding this comment.
Likewise here, this looks accidentally included here.
There was a problem hiding this comment.
Yes, I accidentally included two separate fixes in one PR. Will submit it in a new one.
|
will re-open as separate pull requests. sorry for the confusion |
bclozel
removed
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.