Clarify purpose of build(boolean) method in UriComponentsBuilder

spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java

@@ -440,7 +440,7 @@ public UriComponents build() {
 	/**
 	 * Build a {@code UriComponents} instance from the various components
 	 * contained in this builder.
-	 * @param encoded whether all the components set in this builder are
+	 * @param encoded @param encoded asserts whether all the components set in this builder are already
 	 * encoded ({@code true}) or not ({@code false})
 	 * @return the URI components
 	 */

spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java

@@ -49,6 +49,18 @@
  */
 class UriComponentsBuilderTests {
 
+	@Test
+	public void fromUriStringQueryParamContainingBracket() throws URISyntaxException {
+		URI uri = new URI("http://example.com/some/path?query=[fromto]");
+		URI finalUri = uri;
+		assertThatIllegalArgumentException().isThrownBy(() -> UriComponentsBuilder.fromUri(finalUri).build(true));
+		//ok, then encode it
+		uri = UriComponentsBuilder.fromUri(uri).build(false).encode().toUri();
+		//confirm encoded
+		URI checkUri = UriComponentsBuilder.fromUri(uri).build(true).toUri();
+		assertThat(uri.toString()).isEqualTo(checkUri.toString());
+	}
+
 	@Test
 	void plain() throws URISyntaxException {
 		UriComponentsBuilder builder = UriComponentsBuilder.newInstance();