Support "*" catch-all mappings for MockMvc Filter registrations #28041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
The intent behind #28017 so far is documentation only. This PR changes the behavior and we didn't come to that conclusion yet. Would you like to amend this PR address the original issue? |
bclozel
added
the
status: waiting-for-feedback
|
Could you please tell me exactly how to do that? @bclozel |
spring-projects-issues
added
status: feedback-provided
bclozel
added
for: merge-with-amendments
bclozel
added
the
in: web
|
@bclozel When can you review the PR, please? |
sbrannen
changed the title
* equivalent to /* in PatternMappingFilterProxy
bclozel
changed the title
* equivalent to /* in PatternMappingFilterProxy
|
@funky-eyes Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
bclozel
added
in: test
|
Thanks @funky-eyes for your contribution, this is now merged. |
|
@funky-eyes Thank you for signing the Contributor License Agreement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe most business developers think * is equivalent to /*
fixes #28017