Add ClasspathFileUtil for easy getting files from resource directory #30015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@divinenickname Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@divinenickname Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
I think this is already covered by Thanks for your contribution! |
bclozel
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some tests which needed a json example for reproduction. I think it would be better if we can ability to easy load them or other files from resource directory instead of defining them into class. It'll makes code more clarity and readable.
For example
val body = """ { "bytes": [ 1, 2 ], "array": [ "Foo", "Bar" ], "number": 42, "string": "Foo", "bool": true, "fraction": 42 } """.trimIndent()can be changed to
val body = ResourceClasspathFileUtil("org/springframework/request.json").readText()