Reset Pragma header when caching #840
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Security by default sets a `Pragma: no-cache` header. Even if explicitly calling WebContentGenerator#applyCacheSeconds that header is still present, preventing the browser from caching the resource. So cacheForSeconds should remove the Pragma header if it has been set.
|
This has been resolved with 09e3fc4 in SPR-13252. By the way did you sign our CLA? |
|
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement. |
|
Thanks @felixbarny (just trying to prepare for a smooth upgrade for all Spring developers...) |
|
I've discovered this after upgrading from spring-security 3 to 4 as with version 4, the Pragma header is set by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Security by default sets a
Pragma: no-cacheheader (see CacheControlHeadersWriter). Even if explicitly callingWebContentGenerator#applyCacheSecondsthat header is still present, preventing the browser from caching the resource. SocacheForSecondsshould remove the Pragma header if it has been set.