Handling null in BufferingClientHttpResponseWrapper #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm picking this up in SPR-13563, clarifying getBody's contract there. I'm wondering whether the null return value is actually intended, since the interface javadoc doesn't mention it, and the only implementation ever returning null seems to be HttpComponents(Async)ClientHttpResponse. All the others seem to return an empty body instead, or am I missing something? |
|
Resolved through SPR-13563. Please reopen that JIRA issue if there is anything left to be addressed. |
|
Cool, thanks! The IAE was exactly what we were struggling with, but your solution is way more elegant. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BufferingClientHttpResponseWrapper#getBody brakes the contract for ClientHttpResponse and whenever the response body is null (for instance when 204 is being returned) it throws IllegalArgumentException, while any other implementation is returning null.