Skip to content

@EnableHypermediaSupport does not provide a ContollerEntityLinks bean when using WebFlux #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Sep 1, 2019 · 3 comments
Closed

@EnableHypermediaSupport does not provide a ContollerEntityLinks bean when using WebFlux #1062

wilkinsona opened this issue Sep 1, 2019 · 3 comments
Assignees
@gregturn
Labels
in: documentation Reference documentation stack: webflux stack: webmvc
Milestone
1.0.0.RC2

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Sep 1, 2019 •
edited
Loading

The documentation currently states that ControllerEntityLinks will be included in the default setup but that does not appear to be the case when using WebFlux.
@wilkinsona wilkinsona mentioned this issue Sep 1, 2019
Open
@gregturn
Copy link
Contributor

gregturn commented Sep 3, 2019 •
edited
Loading

I have dug in a little, and discovered that to implement this, we need a WebFluxLinkBuilderFactory. The contract underlying this (WebFluxLinkBuilder) is very different than WebMvcLinkBuilder, as in, Reactor-based types, functional concepts, and different inputs (ServerWebExchange).

I'm not convinced the abstraction in place that creates a ControllerEntityLinks bean by injecting a link building factory is a drop in for WebFlux. It appears heavily driven by Spring MVC.

The implication is that we need something more akin to a WebMvcControllerEntityLinks bean and a WebFluxControllerEntityLinks bean.

Thoughts @odrotbohm?

@gregturn gregturn mentioned this issue Sep 5, 2019
Open
gregturn added a commit that referenced this issue Sep 5, 2019
@gregturn
#1062 - Update reference docs to show EntityLinks are a Spring Web MV…
36baafe 
…C feature.

For now, EntityLinks is only properly support for Spring Web MVC. Developing this for WebFlux is in progress. Properly indicate this in the reference docs.

Related: #1071
@gregturn gregturn self-assigned this Sep 5, 2019
@gregturn gregturn added this to the 1.0.0.RC2 milestone Sep 5, 2019
@gregturn
Copy link
Contributor

gregturn commented Sep 5, 2019

Resolved via 36baafe.

@gregturn gregturn closed this as completed Sep 5, 2019
@gregturn
Copy link
Contributor

gregturn commented Sep 5, 2019

Follow #1071 to track adding a WebFlux-specific EntityLinks variant.

@wilkinsona wilkinsona mentioned this issue Sep 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
in: documentation Reference documentation stack: webflux stack: webmvc
Projects
None yet
Milestone
1.0.0.RC2
Development

No branches or pull requests
2 participants
@gregturn @wilkinsona