Skip to content

addPaginationLinks linked in javadocs does not exist and never has #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jroweboy opened this issue Oct 7, 2016 · 2 comments
Closed

addPaginationLinks linked in javadocs does not exist and never has #501

jroweboy opened this issue Oct 7, 2016 · 2 comments

Comments

@jroweboy
Copy link

jroweboy commented Oct 7, 2016

I've been trying to find some answers about how pagination works in spring-hateoas, but this part has me a little confused. I searched the entire git histroy for the method referenced here https://github.com/spring-projects/spring-hateoas/blob/master/src/main/java/org/springframework/hateoas/PagedResources.java#L116 and it looks like its never existed. I'm curious to know if that see also should just be removed or should that method be written.
@otrosien
Copy link

otrosien commented Dec 7, 2016

There's addPaginationLinks in spring-data-commons (https://github.com/spring-projects/spring-data-commons/blob/db62390de90c93a78743c97cc2cc9ccd964994a5/src/main/java/org/springframework/data/web/PagedResourcesAssembler.java#L208), which is most likely to be meant here.

@gregturn
Copy link
Contributor

Given that Spring Data Commons uses Spring HATEOAS, and not the other way around, the javadocs should have this link cleaned out.

gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
Clean up JavaDocs by removing references to downstream methods.
c8308b6 
Putting in links to downstream methods (Spring Data Commons `PagedResourcesAssembler.addPaginationLinks`) is not advisable.

Resolves #501
@gregturn gregturn mentioned this issue Mar 22, 2017
Merged
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#562 - Clean up JavaDocs by removing references to downstream methods.
ccba8e8 
Putting in links to downstream methods (Spring Data Commons `PagedResourcesAssembler.addPaginationLinks`) is not advisable.

Resolves #501

Polish
gregturn added a commit that referenced this issue Mar 22, 2017
@gregturn
#562 - Clean up JavaDocs by removing references to downstream methods.
d293b07 
Putting in links to downstream methods (Spring Data Commons `PagedResourcesAssembler.addPaginationLinks`) is not advisable.

Resolves #501
odrotbohm pushed a commit that referenced this issue Mar 26, 2017
@gregturn @odrotbohm
#562 - Clean up JavaDocs by removing references to downstream methods.
9f875b2 
Putting in links to downstream methods (Spring Data Commons PagedResourcesAssembler.addPaginationLinks(…)) is not advisable.

Related ticket: #501.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@otrosien @gregturn @jroweboy