Polish doc #419
Closed
Polish doc #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
force-pushed
the
master
branch
2 times, most recently
from
4ebc1be to
266ad50
Compare
gregturn
reviewed
Mar 14, 2017
| @@ -256,14 +256,14 @@ class PersonResourceAssembler extends ResourceAssemblerSupport<Person, PersonRes | |||
| @Override | |||
| public PersonResource toResource(Person person) { | |||
|
|
|||
| PersonResource resource = createResource(person); | |||
| PersonResource resource = createResourceWithId(person); | |||
There was a problem hiding this comment.
This one is actually correct. But your other points are valid.
gregturn
reviewed
Mar 14, 2017
| // … do further mapping | ||
| return resource; | ||
| } | ||
| } | ||
| ---- | ||
|
|
||
| Setting the class up like this gives you the following benefits: there are a hand full of `createResource(…)` methods that will allow you to create an instance of the resource and have it a `Link` with a rel of `self` added to it. The href of that link is determined by the configured controllers request mapping plus the id of the `Identifiable` (e.g. `/people/1` in our case). The resource type gets instantiated by reflection and expects a no-arg constructor. Simply override `instantiateResource(…)` in case you'd like to use a dedicated constructor or avoid the reflection performance overhead. | ||
| Setting the class up like this gives you the following benefits: there are a hand full of `createResourceWithId(…)` methods that will allow you to create an instance of the resource and have it a `Link` with a rel of `self` added to it. The href of that link is determined by the configured controllers request mapping plus the id of the `Identifiable` (e.g. `/people/1` in our case). The resource type gets instantiated by reflection and expects a no-arg constructor. Simply override `instantiateResource(…)` in case you'd like to use a dedicated constructor or avoid the reflection performance overhead. |
gregturn
pushed a commit
that referenced
this pull request
Mar 14, 2017
|
Resolved via 7d9a210 |
odrotbohm
pushed a commit
that referenced
this pull request
Mar 26, 2017
Fixed references to constants in samples for Link. Also use endsWith(…) matcher in sample tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.