Skip to content

Fixed syntax highlighting and content of a few code blocks in the reference guide #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed syntax highlighting and content of a few code blocks in the reference guide #555

wants to merge 1 commit into from

Conversation

behrangsa
Copy link

@behrangsa behrangsa commented Mar 20, 2017 •
edited
Loading

  • Fixed syntax highlighting for 2 JSON code blocks as well as one Java code block.
  • Fixed code block indentation
  • Added the missing leading underscore in the example _link output.

@behrangsa behrangsa changed the title Fixed syntax highlighting of a few code blocks in the reference guide Fixed syntax highlighting and content of a few code blocks in the reference guide Mar 20, 2017
@gregturn gregturn added this to the 0.24 milestone Mar 20, 2017
@gregturn
Copy link
Contributor

@behrangsa Looks good. If you could squash your commits into one and rebase against master we can probably push this through.

@sportrang
#555 - Fixed syntax highlighting of some code blocks in the reference…
dff0f90 
… guide

- Fixed syntax highlighting
- Fixed code block indentation
- Added the missing leading underscore in the example "_link" output.
- Added missing quotes to JSON code blocks
@behrangsa
Copy link
Author

@gregturn done! Added missing quotes around JSON property names too.

@gregturn
Copy link
Contributor

@behrangsa Looks great.

gregturn pushed a commit that referenced this pull request Mar 22, 2017
@sportrang @gregturn
#555 - Fixed syntax highlighting in the reference guide
04aec98 
- Fixed syntax highlighting
- Fixed code block indentation
- Added the missing leading underscore in the example "_link" output.
- Added missing quotes to JSON code blocks
@gregturn
Copy link
Contributor

Resolved via 04aec98

@gregturn gregturn closed this Mar 22, 2017
@gregturn
Copy link
Contributor

@behrangsa As a side note, you may wish to update your github account to avoid this:

screen shot 2017-03-21 at 11 30 57 pm

@behrangsa
Copy link
Author

Thanks for the tip @gregturn. Now GitHub should recognize my work email too.

odrotbohm pushed a commit that referenced this pull request Mar 26, 2017
@sportrang @odrotbohm
#555 - Fixed syntax highlighting in the reference guide.
7bb8d75 
Fixed syntax highlighting. Fixed code block indentation. Added the missing leading underscore in the example "_link" output. Added missing quotes to JSON code blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
0.24
Development

Successfully merging this pull request may close these issues.
3 participants
@behrangsa @gregturn @sportrang