Skip to content

Switch to URI.create() #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Switch to URI.create() #860

wants to merge 2 commits into from

Conversation

gregturn
Copy link
Contributor

@gregturn gregturn commented Mar 8, 2019

URI.create() wraps new URI() and converts a UriSyntaxException into an IllegalArgumentException.

gregturn added a commit that referenced this pull request Mar 8, 2019
@gregturn
#860 - Switch to URI.create() to avoid checked exceptions.
e210d9b 
`URI.create()` wraps `new URI()` and converts a `UriSyntaxException` into an `IllegalArgumentException`.
@gregturn gregturn requested review from odrotbohm and schauder and removed request for odrotbohm March 8, 2019 15:29
@gregturn gregturn self-assigned this Mar 8, 2019
@gregturn gregturn added the in: core Core parts of the project label Mar 8, 2019
@gregturn gregturn added this to the 1.0 M2 milestone Mar 8, 2019
@gregturn
Copy link
Contributor Author

gregturn commented Mar 9, 2019

Looks like the examples can leverage Link.toLink() which is the same thing.

@odrotbohm
Copy link
Member

I've recently introduced Link.toUri() for sort of that purpose. Do you think we can move to that instead?

gregturn added a commit that referenced this pull request Mar 11, 2019
@gregturn
#860 - Switch to URI.create() and toUri() to avoid checked exceptions.
a8dddaa 
`URI.create()` wraps `new URI()` and converts a `UriSyntaxException` into an `IllegalArgumentException`.

Also, take advantage of `toUri()`.
@gregturn
#860 - Switch to URI.create() and toUri() to avoid checked exceptions.
347a06c 
`URI.create()` wraps `new URI()` and converts a `UriSyntaxException` into an `IllegalArgumentException`.

Also, take advantage of `toUri()`.
@gregturn
Copy link
Contributor Author

@odrotbohm Done!

@schauder
#860 - Polishing.
5d41903 
Removed some superfluous variables.
Replaces Hamcrest with AssertJ.
Formatting.
@schauder
Copy link
Contributor

I added some minor polish.
Other than that it looks fine to me.

@gregturn
Copy link
Contributor Author

Thanks @schauder!

gregturn added a commit that referenced this pull request Mar 12, 2019
@gregturn
#860 - Switch to URI.create() and toUri() to avoid checked exceptions.
c35a700 
`URI.create()` wraps `new URI()` and converts a `UriSyntaxException` into an `IllegalArgumentException`.

Also, take advantage of `toUri()`.
gregturn pushed a commit that referenced this pull request Mar 12, 2019
@schauder @gregturn
#860 - Polishing.
dbf9e4b 
Removed some superfluous variables.
Replaces Hamcrest with AssertJ.
Formatting.
@gregturn gregturn closed this Mar 12, 2019
@gregturn gregturn deleted the uri branch March 12, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schauder schauder Awaiting requested review from schauder

@odrotbohm odrotbohm Awaiting requested review from odrotbohm

Assignees

@gregturn gregturn

Labels
in: core Core parts of the project
Projects
None yet
Milestone
1.0 M2
Development

Successfully merging this pull request may close these issues.
3 participants
@gregturn @odrotbohm @schauder