Revise all the throws Exception; // NOSONAR

[artembilan]

For example we have a code in the WebSocketListener like this:

void onMessage(WebSocketSession session, WebSocketMessage<?> message)
			throws Exception; // NOSONAR Remove in 5.2

so, all those throws Exception have to be removed.

[askzy]

is this for every class in the entire codebase?
any guidelines on how to revise these throw exceptions?

[artembilan]

I just did a search for this sentence: throws Exception; // NOSONAR:

So, not too much.

The goal is to not have such a generic throws Exception; at all.
The revision indeed depends on the impl of such a contract: sometimes it is going to work as is because the impl already does a good job for error handling or it just re-throw a RuntimeException which doesn't require throws Exception; contract.

In other places we would need to what exceptions are thrown and re-throw them as some particular RuntimeException: sometimes an IllegalStateException is enough; sometimes it has to be a MessagingException...

Let's see what is going on when you just remove them and build the project gradlew check !

[mipo256]

@artembilan I think I can take care of that

[artembilan]

Sure!

Just pull the latest main, switch to Java 17 and go ahead with the fix!

Feel free to PR or leave comments over here if something is off or out of your control.

Thank you!

[aml8801]

Hello guys
@Mikhail2048 are you still on this issue?
If not, I would like to do it.

best regards

[artembilan]

Hi @aml8801 !

You know it doesn't matter for the project who contributes the fix and since there is no any news from @mikhail2048 for a couple months already, I think it is safe for you to take this issue and PR the fix.

Thank you!