Fix for issue #492: Support UTF8 characters in attributes values for … #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes values for LDIF's DefaultAttributeValidationPolicy in order to comply with RFC2849
|
@naorbar Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@naorbar Thank you for signing the Contributor License Agreement! |
|
@naorbar Thanks for the PR! Unfortunately one of the tests is now failing in Travis Can you push a fix to the code? |
rwinch
requested changes
Sep 12, 2018
|
Rob, |
rwinch
approved these changes
Sep 13, 2018
|
@naorbar Thanks for fixing the build! This is now merged into master |
|
With pleasure. Let me know if I can help in the future... |
naorbar
deleted the
naorbar_fix_for_issue#492_support_UTF8_characters_in_LDIFParser
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…LDIF's DefaultAttributeValidationPolicy in order to comply with RFC2849