Skip to content

Build using openjdk8 #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Build using openjdk8 #550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6093857
Build using openjdk8
antoine777 Mar 31, 2020
b027612
fix gradle wrapper distributionUrl
antoine777 Mar 31, 2020
68709a9
fix javacc download url
antoine777 Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
language: java

jdk:
- oraclejdk8
- openjdk8

os:
- linux
Expand Down
2 changes: 1 addition & 1 deletion core/javacc.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
task downloadJavacc {
ext.file = "javacc-5.0.tar.gz"
ext.dest = file("$buildDir/javacc/$file")
ext.url = "https://javacc.org/downloads/$file"
ext.url = "http://download.openpkg.org/components/cache/javacc/$file"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that this was updated for using openjdk8? If we do this we'd like this to be a URL that works over https.

Copy link
Contributor Author

@antoine777 antoine777 Apr 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason with openjdk8.
It is another issue with the gradle build (last successful build was 1 year ago).
I didn't find an URL over https which serve javacc-5.0.tar.gz (i don"t know why this version does not exist on the new javacc download page https://github.com/javacc/javacc/releases)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split this up into another PR. The openjdk8 is a no brainer. It appears due to this not being available over https, javacc may take a bit more work.


outputs.file dest

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=http\://services.gradle.org/distributions/gradle-3.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch here. I'd prefer things to be distinct commits so I went ahead and pushed a separate commit to fix this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK