Skip to content

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Aug 6, 2022

  • Each module has its own build.gradle
  • Functionality moved into plugins in buildSrc/
  • Add Spring javaformat
  • Add release plugins (CI Pipeline for release #20)

Fixes #21

NOTES

  • ℹ️ This PR contains many things and is large. I would normally not do this, but because it is in experimental stage I took the liberty. The build refactor introduced Spring Javaformat which in turn formatted many source files. There are no. code changes in the source files - only moves (rename) and formatting.

Next steps

  • I will create/add to a CONTRIBUTING.doc that talks about running format etc..
  • Create SB starter module and cleanup deps across the project (versions, duplicates etc..)

* Each module has its own build.gradle
* Functionality moved into plugins in buildSrc/
* Add Spring javaformat
* Add release plugins (spring-projects#20)

Fixes spring-projects#21
# GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }}
run: |
./gradlew clean build --rerun-tasks -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD"
./gradlew clean build --continue --scan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Artifactory is not used during PR build

paths-ignore:
- '.github/**'
schedule:
- cron: '0 10 * * *' # Once per day at 10am UTC
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[UNRELATED] Also schedule this to build daily

# GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_SECRET_ACCESS_KEY }}
run: |
./gradlew clean build --refresh-dependencies --stacktrace -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD"
./gradlew clean build --continue -PartifactoryUsername="$ARTIFACTORY_USERNAME" -PartifactoryPassword="$ARTIFACTORY_PASSWORD"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[UNRELATED] the refresh was left in while debugging something previously

# env:
# ORG_GRADLE_PROJECT_signingKey: ${{ secrets.GPG_PRIVATE_KEY }}
# ORG_GRADLE_PROJECT_signingPassword: ${{ secrets.GPG_PASSPHRASE }}
# OSSRH_TOKEN_USERNAME: ${{ secrets.OSSRH_S01_TOKEN_USERNAME }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These will be added during #20

@onobc onobc merged commit de2d8a0 into spring-projects:main Aug 6, 2022
@onobc onobc deleted the cbono-starter-module branch August 6, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Spring javaformat to project

1 participant