Skip to content

Include cookies in request snippets #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tkopczynski
Copy link
Contributor

This adds cookies to curl, HTTP and httpie request snippets.

In HTTP and httpie snippets it simply adds a Cookie header for each cookie. In the curl snippet it uses the --cookie option.

Fixes #302 #303 #304

@wilkinsona
Copy link
Member

Nice! Thanks for the PR

@wilkinsona wilkinsona added this to the 1.2.0.RC1 milestone Dec 29, 2016
@wilkinsona wilkinsona added the type: enhancement Enhancement that adds a new feature label Dec 29, 2016
@tkopczynski
Copy link
Contributor Author

@wilkinsona I'm glad you like it.
I'd like to continue this with a PR to support cookies in response snippets. It feels that I would need to use some of the code written already here, so what are your plans on merging this?

@wilkinsona
Copy link
Member

@tkopczynski Soon, I hope. I'm just catching up after the holidays. Sorry for the delay, but it will definitely be in 1.2.0.RC1.

@wilkinsona wilkinsona closed this in 25bc6c3 Feb 2, 2017
wilkinsona added a commit that referenced this pull request Feb 2, 2017
wilkinsona added a commit that referenced this pull request Feb 2, 2017
* gh-336:
  Polish "Include cookies in request snippets"
  Include cookies in request snippets
meistermeier pushed a commit to meistermeier/spring-restdocs that referenced this pull request Feb 8, 2017
meistermeier pushed a commit to meistermeier/spring-restdocs that referenced this pull request Feb 8, 2017
meistermeier pushed a commit to meistermeier/spring-restdocs that referenced this pull request Feb 25, 2017
meistermeier pushed a commit to meistermeier/spring-restdocs that referenced this pull request Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancement that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants