Skip to content

Polish tests #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Polish tests #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...docs-core/src/test/java/org/springframework/restdocs/payload/JsonFieldProcessorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,21 +175,21 @@ public void extractArraysFromItemsInNestedArray() {

@Test(expected = FieldDoesNotExistException.class)
public void nonExistentTopLevelField() {
this.fieldProcessor.extract("a", Collections.emptyMap()).getValue();
this.fieldProcessor.extract("a", Collections.emptyMap());
}

@Test(expected = FieldDoesNotExistException.class)
public void nonExistentNestedField() {
HashMap<String, Object> payload = new HashMap<>();
payload.put("a", new HashMap<String, Object>());
this.fieldProcessor.extract("a.b", payload).getValue();
this.fieldProcessor.extract("a.b", payload);
}

@Test(expected = FieldDoesNotExistException.class)
public void nonExistentNestedFieldWhenParentIsNotAMap() {
HashMap<String, Object> payload = new HashMap<>();
payload.put("a", 5);
this.fieldProcessor.extract("a.b", payload).getValue();
this.fieldProcessor.extract("a.b", payload);
}

@Test(expected = FieldDoesNotExistException.class)
Expand All @@ -198,20 +198,20 @@ public void nonExistentFieldWhenParentIsAnArray() {
HashMap<String, Object> alpha = new HashMap<>();
alpha.put("b", Arrays.asList(new HashMap<String, Object>()));
payload.put("a", alpha);
this.fieldProcessor.extract("a.b.c", payload).getValue();
this.fieldProcessor.extract("a.b.c", payload);
}

@Test(expected = FieldDoesNotExistException.class)
public void nonExistentArrayField() {
HashMap<String, Object> payload = new HashMap<>();
this.fieldProcessor.extract("a[]", payload).getValue();
this.fieldProcessor.extract("a[]", payload);
}

@Test(expected = FieldDoesNotExistException.class)
public void nonExistentArrayFieldAsTypeDoesNotMatch() {
HashMap<String, Object> payload = new HashMap<>();
payload.put("a", 5);
this.fieldProcessor.extract("a[]", payload).getValue();
this.fieldProcessor.extract("a[]", payload);
}

@Test(expected = FieldDoesNotExistException.class)
Expand All @@ -220,7 +220,7 @@ public void nonExistentFieldBeneathAnArray() {
HashMap<String, Object> alpha = new HashMap<>();
alpha.put("b", Arrays.asList(new HashMap<String, Object>()));
payload.put("a", alpha);
this.fieldProcessor.extract("a.b[].id", payload).getValue();
this.fieldProcessor.extract("a.b[].id", payload);
}

@Test
Expand Down