Skip to content

Conversation

hpoettker
Copy link
Contributor

This is a follow-up on #322. Sorry for bothering you twice!

Using the annotation @CircuitBreaker with Spring Framework 6 leads to the following warning:

WARN org.springframework.core.annotation.AnnotationTypeMapping [main] : Support for convention-based annotation attribute overrides is deprecated and will be removed in Spring Framework 6.1. Please annotate the following attributes in @org.springframework.retry.annotation.CircuitBreaker with appropriate @AliasFor declarations: [include, maxAttempts, noRetryFor, maxAttemptsExpression, notRecoverable, exclude, exceptionExpression, label, retryFor]

It can be seen e.g. when running CircuitBreakerTests.

I also took the liberty to mark CircuitBreaker::value as deprecated because the field Retryable::value that it's aliasing is also deprecated.

The two changes in the tests are not required for a successful build. I've just replaced deprecated fields where the respective favored fields are currently not used in any test.

@artembilan
Copy link
Member

@hpoettker ,

thank you very much for the contribution; looking forward for more!

@hpoettker hpoettker deleted the alias-for branch November 18, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnnotationTypeMapping warning when using @CircuitBreaker with Spring Framework 6
2 participants