Skip to content

Add package javadoc to remaining packages #11422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rwinch opened this issue Jun 21, 2022 · 1 comment
Open

Add package javadoc to remaining packages #11422

rwinch opened this issue Jun 21, 2022 · 1 comment
Labels
in: build An issue in the build type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Jun 21, 2022 •
edited
Loading

spring-javaformat-checkstyle 0.032+ requires package javadoc which breaks the Spring Security Build. We need to fix the build to work with these changes and update the version. See gh-328
@rwinch rwinch added in: build An issue in the build type: dependency-upgrade A dependency upgrade labels Jun 21, 2022
marcusdacoregio added a commit that referenced this issue Jul 15, 2022
@marcusdacoregio
Exclude JavadocPackageCheck from Spring Checks
ee11c3a 
Issue gh-11422
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Jul 15, 2022 •
edited
Loading

The dependency was updated by this commit c214c6c and I've added this commit to exclude the JavadocPackageCheck for now ee11c3a. This commit should be reverted as soon as we have the package javadocs in place

@marcusdacoregio marcusdacoregio changed the title Update to latest spring-javaformat Add package javadoc to remaining packages Jul 15, 2022
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels Jul 15, 2022
sjohnr pushed a commit that referenced this issue Jul 15, 2022
Exclude JavadocPackageCheck from Spring Checks
1be9be9 
Issue gh-11422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwinch @marcusdacoregio