-
Notifications
You must be signed in to change notification settings - Fork 6k
Migrate Groovy to Java #4939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a suggestion how to migrate the GebSpec based tests to Java / Selenium based tests. Issue: spring-projectsgh-4939
This is a suggestion how to migrate the GebSpec based tests to Java / Selenium based tests. Issue: gh-4939
Next: xml-jaas |
Next: javaconfig-form |
Migrate |
Next: javaconfig-jdbc |
I will have the rest of the samples ready by the end of the weekend. |
@michael-simons Thank you for your continued efforts. We would like to migrate all Groovy within Spring Security to Java. When looking at the spring-security-java-config classes, I'd take a look at using SpringTestRule (example usage) Does that help? |
Yep, that was the question. Thanks. |
@michael-simons Awesome. I think you were too quick for my edits so as an FYI I added a little more information above. Thanks again for your help! |
@jzheaux , I will try to migrate org.springframework.security.config.annotation.web.configurers tests |
Formatted HttpSecurity and WebSecurity configuration stacks Removed unnecessary code Issue gh-4939
Next: integration tests for the LDAP management |
This commit also removes BaseSpringSpec Issue: spring-projectsgh-4939
This commit also removes BaseSpringSpec Issue: gh-4939
I'm taking the cas sample. |
I'm starting on |
Summary
The tests that are written in Groovy are very convenient and easy to read, but place an unnecessary burden on contributors unfamiliar with Groovy. We should migrate the Groovy tests to Java.
For the samples using Geb, take a look at https://github.com/spring-projects/spring-security/tree/b9152701a65df5b3fa78fe4bd2a946018f9ca352/samples/javaconfig/webflux-form/src/integration-test/java/sample
The following commits in Spring Session might be useful as well
spring-projects/spring-session@1a318b8
and
spring-projects/spring-session@8e7c736
Anyone taking on this task I'd encourage them to break it up into multiple PRs that migrate smaller portions at a time (i.e. a sample or a package) and include
I'd also encourage contributors to comment on this issue to state which piece they are going to start working on migrating. This will allow multiple people to help tackle this large issue and avoid duplicating efforts.
The text was updated successfully, but these errors were encountered: