Skip to content

Migrate Groovy to Java #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Jan 2, 2018 · 31 comments
Closed

Migrate Groovy to Java #4939

rwinch opened this issue Jan 2, 2018 · 31 comments
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Jan 2, 2018

Summary

The tests that are written in Groovy are very convenient and easy to read, but place an unnecessary burden on contributors unfamiliar with Groovy. We should migrate the Groovy tests to Java.

For the samples using Geb, take a look at https://github.com/spring-projects/spring-security/tree/b9152701a65df5b3fa78fe4bd2a946018f9ca352/samples/javaconfig/webflux-form/src/integration-test/java/sample

The following commits in Spring Session might be useful as well

spring-projects/spring-session@1a318b8

and

spring-projects/spring-session@8e7c736

Anyone taking on this task I'd encourage them to break it up into multiple PRs that migrate smaller portions at a time (i.e. a sample or a package) and include

Migrate <what is migrated> groovy->java

(optional additional details)

Issue: gh-4939

I'd also encourage contributors to comment on this issue to state which piece they are going to start working on migrating. This will allow multiple people to help tackle this large issue and avoid duplicating efforts.

@rwinch rwinch added in: build An issue in the build type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jan 2, 2018
michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 3, 2018
This is a suggestion how to migrate the GebSpec based tests to Java / Selenium based tests.

Issue: spring-projectsgh-4939
rwinch pushed a commit that referenced this issue Jan 3, 2018
This is a suggestion how to migrate the GebSpec based tests to Java / Selenium based tests.

Issue: gh-4939
@michael-simons
Copy link
Contributor

Next: xml-jaas

@michael-simons
Copy link
Contributor

Next: javaconfig-form

@adolfoweloy
Copy link
Contributor

Migrate UserDetailsManagerConfigurerTests test groovy->java from security-config #4949

@michael-simons
Copy link
Contributor

Next: javaconfig-jdbc

michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 9, 2018
rwinch pushed a commit that referenced this issue Jan 10, 2018
rwinch pushed a commit that referenced this issue Jan 10, 2018
michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 11, 2018
michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 11, 2018
michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 11, 2018
@michael-simons
Copy link
Contributor

I will have the rest of the samples ready by the end of the weekend.
One question though: There are more Groovy tests, also dedicated to tickets and stuff. Do you want to migrate them as well?

@rwinch
Copy link
Member Author

rwinch commented Jan 12, 2018

@michael-simons Thank you for your continued efforts. We would like to migrate all Groovy within Spring Security to Java. When looking at the spring-security-java-config classes, I'd take a look at using SpringTestRule (example usage)

Does that help?

@michael-simons
Copy link
Contributor

Yep, that was the question. Thanks.

@rwinch
Copy link
Member Author

rwinch commented Jan 12, 2018

@michael-simons Awesome. I think you were too quick for my edits so as an FYI I added a little more information above. Thanks again for your help!

michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 13, 2018
michael-simons added a commit to michael-simons/spring-security that referenced this issue Jan 15, 2018
rwinch pushed a commit that referenced this issue Jan 24, 2018
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
jzheaux added a commit that referenced this issue Aug 30, 2019
jzheaux added a commit that referenced this issue Sep 2, 2019
@kostya05983
Copy link
Contributor

@jzheaux , I will try to migrate org.springframework.security.config.annotation.web.configurers tests

jzheaux added a commit that referenced this issue Sep 16, 2019
Formatted HttpSecurity and WebSecurity configuration stacks
Removed unnecessary code

Issue gh-4939
jzheaux added a commit that referenced this issue Sep 27, 2019
jzheaux added a commit that referenced this issue Sep 27, 2019
jzheaux added a commit that referenced this issue Sep 27, 2019
@ghostd
Copy link
Contributor

ghostd commented Dec 1, 2019

Next: integration tests for the LDAP management

ghostd added a commit to ghostd/spring-security that referenced this issue Jan 13, 2020
This commit also removes BaseSpringSpec

Issue: spring-projectsgh-4939
eleftherias pushed a commit that referenced this issue Jan 13, 2020
This commit also removes BaseSpringSpec

Issue: gh-4939
@jzheaux
Copy link
Contributor

jzheaux commented Feb 6, 2020

I'm taking the cas sample.

jzheaux added a commit that referenced this issue Feb 8, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Feb 8, 2020

I'm starting on org.springframework.security.web.context.AbstractSecurityWebApplicationInitializerTests (last one!)

jzheaux added a commit that referenced this issue Feb 10, 2020
@jzheaux jzheaux added this to the 5.3.0 milestone Feb 10, 2020
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

7 participants