-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Labels
in: saml2An issue in SAML2 modulesAn issue in SAML2 modulestype: enhancementA general enhancementA general enhancement
Milestone
Description
Describe the bug
The InResponseTo field is not validated and the repsonse is not rejected when this does not correspond to a sent request.
To Reproduce
- Set up SAML2 login and run your server locally which redirects to an IDP which will then redirect to an actual deployed SAML2 authentication endpoint.
- Set the host of your deployed app to 127.0.0.1 in /etc/hosts
- Ping the host and verify that localhost responds
- Start the local app and try to log in, you will be directed to your IDP which will redirect back to the authentication endpoint which will not exist on your local machine, thereby resulting in a not found error.
- Copy the unresponded request as cURL from the console and paste it in a document.
- Add flags .L and -i and remove cookies headers to be on the safe side.
- Remove the entry in /etc/hosts and verify that the actual deployed application responds on ping.
- Run the command with cURL and verify that the deployed application authentication endpoint accepts the cURL command which is a response to a request NOT initiated by the deployed application but by the local application.
Expected behavior
If the request contains a InResponseTo which is incorrect, it should be rejected.
Sample
A link to a GitHub repository with a minimal, reproducible sample.
Reports that include a sample will take priority over reports that do not.
At times, we may require a sample, so it is good to try and include a sample up front.
Metadata
Metadata
Assignees
Labels
in: saml2An issue in SAML2 modulesAn issue in SAML2 modulestype: enhancementA general enhancementA general enhancement