OidcClientInitiatedLogoutSuccessHandler resolves redirect uri placeholders
#10935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enkosz
changed the title
OidcClientInitiatedLogoutSuccessHandler resolves redirect uri placeholders
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
added
in: oauth2
|
Thanks, @Enkosz. Yes, please update the copyright headers and adjust the commit message. You can read more about both in our contributing guidelines. |
|
@jzheaux i've changed the copyright headers, commit message and fixed the code formatting! |
- OidcClientInitiatedLogoutSuccessHandler can automatically resolve placeholders like baseUrl and registrationId inside the postLogoutRedirectUri Issue spring-projectsgh-7900
jzheaux
added
status: duplicate
|
Thanks, @Enkosz! This is now merged into |
|
@jzheaux thanks! let me know if i can help with other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes based on issue gh-7900
OidcClientInitiatedLogoutSuccessHandleris now able to replace{baseUrl}and{registrationId}inside the redirect uriOidcClientInitiatedLogoutSuccessHandlerTeststo verify the correct replace of the placeholdersLet me know if commit messages, test names, or something else can be wrong, i have also noticed that the Copyright and License dates are wrong in those classes should i fix them?
CLA already signed ✅
Issue gh-7900