Suggest replacing size() == 0 with isEmpty() for collection check #16428
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Consider using isEmpty() instead of size() == 0 to improve code readability and follow modern Java practices. Signed-off-by: 2-say <[email protected]>
2-say
force-pushed
the
refactor-replace-size-check-with-isEmpty
branch
from
f09f74f to
5af136e
Compare
jzheaux
added
in: core
|
Thanks for this PR, @2-say!
You don't need to apologize. Your PR made a good point and, anyway, supporting contributors is one of the best parts of open source! I hope you submit more PRs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion: Consider using isEmpty() instead of size() == 0
I hope this doesn’t cause any inconvenience, but I was wondering if there’s a specific reason why size() == 0 is used instead of isEmpty(). Using isEmpty() can make the code more readable and aligns with modern Java practices. It conveys the intent more clearly, improving overall clarity.
I apologize for taking your time and appreciate your consideration.