-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Jackson Support for Objects stored in HttpSession #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ackson deserialization support
…ed in CasAuthenticationToken jackson deserialization
Thanks for the feedback! |
@rwinch , can this be backported to Spring Security? |
@driverpt Spring Security 4.2 will be out very soon, so I don't think we will be back porting it. What version do you want it to be back ported to? |
@rwinch , thanks for the quick reply. I'm currently using the one used in Spring Boot (4.1.1). Is 4.2.0 M1 a good drop-in replacement for 4.1.1 in Spring Boot ? |
Problem is, Spring Boot uses Jackson 2.8.1 |
Hi @rwinch sorry it's got delayed. I've created mix-ins to add Jackson support(#3736).
Please review the code and let me know feedback. I've modified some existing classes
DefaultSavedRequest
added builder class with private constructorWebAuthenticationDetails
added one private constructor to excludeHttpServletRequest
dependency in Jackson deserialization.CasAuthenticationToken
,RememberMeAuthenticationToken
,AnonymousAuthenticationToken
added new private constructor to ensurekeyHash
correctly deserialized and added static methods inAbstractAuthenticationToken
which helps in constructing these *AuthenticationToken implementationsPS: I havn't update Apache Licence yet. Need your help in updating the same