Preserve existing refresh token if new refresh token not returned #6504
Conversation
|
@farrault Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@farrault Thank you for signing the Contributor License Agreement! |
farrault
force-pushed
the
gh-6503-no-refresh-token-during-refresh
branch
2 times, most recently
from
64b3ccf to
4ce6ba1
Compare
| } | ||
|
|
||
| @Test | ||
| public void filterWhenRefreshRequiredThenRefreshButRefreshResponseHasNotNewRefreshToken() { |
There was a problem hiding this comment.
Let's rename to filterWhenRefreshRequiredThenRefreshAndResponseDoesNotContainRefreshToken
| @@ -94,6 +96,9 @@ | |||
| @Mock | |||
| private ServerWebExchange serverWebExchange; | |||
|
|
|||
| @Captor | |||
| private ArgumentCaptor<OAuth2AuthorizedClient> oauth2AuthorizedClientCaptor; | |||
There was a problem hiding this comment.
Let's rename to authorizedClientCaptor
| } | ||
|
|
||
| @Test | ||
| public void filterWhenRefreshRequiredThenRefreshButRefreshResponseHasNotNewRefreshToken() { |
There was a problem hiding this comment.
Let's rename to filterWhenRefreshRequiredThenRefreshAndResponseDoesNotContainRefreshToken
| @@ -101,6 +101,8 @@ | |||
| private WebClient.RequestHeadersSpec<?> spec; | |||
| @Captor | |||
| private ArgumentCaptor<Consumer<Map<String, Object>>> attrs; | |||
| @Captor | |||
| private ArgumentCaptor<OAuth2AuthorizedClient> oauth2AuthorizedClientCaptor; | |||
There was a problem hiding this comment.
Let's rename to authorizedClientCaptor
jgrandja
changed the title
jgrandja
added
type: bug
There was a problem hiding this comment.
Thanks for the PR @farrault! I have one additional comment to Joe's feedback.
Can you please update the commit message to align with the Spring Security conventions? Specifically can you ensure it ends with Fixes: gh-6503
farrault
force-pushed
the
gh-6503-no-refresh-token-during-refresh
branch
from
4ce6ba1 to
92e0cf0
Compare
…new refresh token, preserve the existing one Fixes: spring-projectsgh-6503
farrault
force-pushed
the
gh-6503-no-refresh-token-during-refresh
branch
from
92e0cf0 to
b2e5da0
Compare
|
@farrault Thanks so much for the PR! The commit message needed to be updated - first line should be short (50 chars or less) summary of changes. I updated it for you and merged this to master. We appreciate your contribution and look forward to the next one :) |
During a oauth2 refresh if the authorization server doesn't return a new refresh token, keep the previous one
fix #6503