Skip to content

Allowing for a @Bean of type OAuth2AccessTokenResponseClient<OAuth2Cl… #6606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allowing for a @Bean of type OAuth2AccessTokenResponseClient<OAuth2Cl… #6606

wants to merge 1 commit into from

Conversation

fritzdj
Copy link
Contributor

@fritzdj fritzdj commented Mar 10, 2019

Allowing for a @bean of type OAuth2AccessTokenResponseClient to be discovered by OAuth2ClientConfiguration

Fixes gh-6572
#6572

@pivotal-issuemaster
Copy link

@fritzdj Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@fritzdj Thank you for signing the Contributor License Agreement!

@fritzdj
Copy link
Contributor Author

fritzdj commented Mar 10, 2019

@jgrandja, I wasn't sure what the best way to test this was. Ideally we could check that a OAuth2AuthorizedClientArgumentResolver with the autowired OAuth2AccessTokenResponseClient was added to the HandlerMethodArgumentResolver. Please let me know if this is needed / how to best do that.

@jgrandja jgrandja self-assigned this Mar 13, 2019
jgrandja
jgrandja requested changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @fritzdj. Please see my comments.

fritzdj
fritzdj commented Mar 17, 2019
View reviewed changes
Copy link
Contributor Author

@fritzdj fritzdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgrandja, please see my updates

jgrandja
jgrandja requested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @fritzdj. Please see my comments for a couple of minor changes.

@fritzdj
Copy link
Contributor Author

fritzdj commented Mar 21, 2019

Thanks for the updates @fritzdj. Please see my comments for a couple of minor changes.

Thanks again for the help on this - all of those minor changes should be included now.

@jgrandja
Copy link
Contributor

Thanks @fritzdj. I left one more comment and after that we are ready to merge. But before we merge, can you please squash the commits to 1 and ensure the commit message follows this format. Thanks for your work on this!

@fritzdj
Allowing for a @bean of type OAuth2AccessTokenResponseClient<OAuth2Cl…
c61c11e 
…ientCredentialsGrantRequest> to be discovered by OAuth2ClientConfiguration

Fixes gh-6572
@fritzdj
Copy link
Contributor Author

fritzdj commented Mar 21, 2019

@jgrandja, thanks again for your help on the change and helping walk me through this process. Definitely time consuming for you, but now I have the hang of it for future changes :)

@jgrandja jgrandja added in: config An issue in spring-security-config type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Mar 21, 2019
@jgrandja jgrandja added this to the 5.2.0.M2 milestone Mar 21, 2019
@jgrandja
Copy link
Contributor

@fritzdj Thanks again for your work. This is now in master bfe1e6a !

As an FYI, I shortened the commit message a bit to get closer to the 50 chars or less summary.

Looking forward to some more contributions as your time permits.

@jgrandja jgrandja closed this Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja jgrandja requested changes

Assignees

@jgrandja jgrandja

Labels
in: config An issue in spring-security-config in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M2
Development

Successfully merging this pull request may close these issues.
3 participants
@fritzdj @pivotal-issuemaster @jgrandja